Assume GV is not null for now.
authorRafael Espindola <rafael.espindola@gmail.com>
Wed, 9 Mar 2016 00:31:06 +0000 (00:31 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Wed, 9 Mar 2016 00:31:06 +0000 (00:31 +0000)
It will come back when we add support for inline asm in .bc files.

llvm-svn: 262972

lld/ELF/InputFiles.cpp

index 96499ea..2986cb0 100644 (file)
@@ -438,17 +438,15 @@ void BitcodeFile::parse(DenseSet<StringRef> &ComdatGroups) {
   }
 
   for (const BasicSymbolRef &Sym : Obj->symbols()) {
-    uint8_t Visibility = STV_DEFAULT;
     const GlobalValue *GV = Obj->getSymbolGV(Sym.getRawDataRefImpl());
+    assert(GV);
     uint32_t Flags = Sym.getFlags();
-    if (GV) {
-      if (const Comdat *C = GV->getComdat())
-        if (!KeptComdats.count(C))
-          continue;
-      if (!(Flags & object::BasicSymbolRef::SF_Global))
+    if (const Comdat *C = GV->getComdat())
+      if (!KeptComdats.count(C))
         continue;
-      Visibility = getGvVisibility(GV);
-    }
+    if (!(Flags & object::BasicSymbolRef::SF_Global))
+        continue;
+    uint8_t Visibility = getGvVisibility(GV);
 
     SmallString<64> Name;
     raw_svector_ostream OS(Name);