bpf, sockmap: Use truesize with sk_rmem_schedule()
authorJohn Fastabend <john.fastabend@gmail.com>
Mon, 16 Nov 2020 22:28:26 +0000 (14:28 -0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Tue, 17 Nov 2020 23:12:37 +0000 (00:12 +0100)
We use skb->size with sk_rmem_scheduled() which is not correct. Instead
use truesize to align with socket and tcp stack usage of sk_rmem_schedule.

Suggested-by: Daniel Borkman <daniel@iogearbox.net>
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com>
Link: https://lore.kernel.org/bpf/160556570616.73229.17003722112077507863.stgit@john-XPS-13-9370
net/core/skmsg.c

index fe44280..d09426c 100644 (file)
@@ -411,7 +411,7 @@ static int sk_psock_skb_ingress(struct sk_psock *psock, struct sk_buff *skb)
        msg = kzalloc(sizeof(*msg), __GFP_NOWARN | GFP_ATOMIC);
        if (unlikely(!msg))
                return -EAGAIN;
-       if (!sk_rmem_schedule(sk, skb, skb->len)) {
+       if (!sk_rmem_schedule(sk, skb, skb->truesize)) {
                kfree(msg);
                return -EAGAIN;
        }