soc: qcom: smem: fix first cache entry calculation
authorAlex Elder <elder@linaro.org>
Tue, 10 Apr 2018 22:25:37 +0000 (17:25 -0500)
committerAndy Gross <andy.gross@linaro.org>
Fri, 25 May 2018 20:53:53 +0000 (15:53 -0500)
Cached items are found at the high end of an smem partition.  A
cached item's shared memory precedes the private entry structure
that describes it.

The address of the structure describing the first cached item should
be returned by phdr_to_first_cached_entry().  However the function
calculates the start address using the wrong structure size.

Fix this by computing the first item's entry structure address by
subtracting the size of a private entry structure rather than a
partition header structure.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
drivers/soc/qcom/smem.c

index 0b94d62..7f38c5e 100644 (file)
@@ -292,8 +292,9 @@ static void *phdr_to_first_cached_entry(struct smem_partition_header *phdr,
                                        size_t cacheline)
 {
        void *p = phdr;
+       struct smem_private_entry *e;
 
-       return p + le32_to_cpu(phdr->size) - ALIGN(sizeof(*phdr), cacheline);
+       return p + le32_to_cpu(phdr->size) - ALIGN(sizeof(*e), cacheline);
 }
 
 static void *phdr_to_last_cached_entry(struct smem_partition_header *phdr)