genlist - fix coverity complaint about null check
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Tue, 18 Apr 2017 07:58:04 +0000 (16:58 +0900)
committerCarsten Haitzler (Rasterman) <raster@rasterman.com>
Tue, 18 Apr 2017 08:30:50 +0000 (17:30 +0900)
we checked for null and then just used a null return later inthe loop.
this fixes that. this should fix CID 1360955

src/lib/elementary/elm_genlist.c

index 360bbcb..b657e57 100644 (file)
@@ -7745,8 +7745,9 @@ _filter_queue_process(Elm_Genlist_Data *sd)
    for (n = 0; ((sd->filter_queue) && (sd->processed_count < ITEM_QUEUE_MAX)); n++)
      {
         it = eina_list_data_get(sd->filter_queue);
+        if (!it) break;
         //FIXME: This is added as a fail safe code for items not yet processed.
-        if (it && it->item->queued)
+        if (it->item->queued)
           {
              sd->filter_queue = eina_list_remove_list
                               (sd->filter_queue, sd->filter_queue);