Staging: hv: storvsc: No need to copy from bounce buffer in case of a failure
authorK. Y. Srinivasan <kys@microsoft.com>
Sat, 27 Aug 2011 18:31:29 +0000 (11:31 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 29 Aug 2011 18:01:09 +0000 (11:01 -0700)
No need to copy from bounce buffer in case of a failure; cleanup the code
accordingly.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/hv/storvsc_drv.c

index 22a1d75..d575bc9 100644 (file)
@@ -1315,17 +1315,9 @@ retry_request:
        if (ret == -EAGAIN) {
                /* no more space */
 
-               if (cmd_request->bounce_sgl_count) {
-                       /*
-                        * FIXME: We can optimize on writes by just skipping
-                        * this
-                        */
-                       copy_from_bounce_buffer(scsi_sglist(scmnd),
-                                               cmd_request->bounce_sgl,
-                                               scsi_sg_count(scmnd));
+               if (cmd_request->bounce_sgl_count)
                        destroy_bounce_buffer(cmd_request->bounce_sgl,
-                                             cmd_request->bounce_sgl_count);
-               }
+                                       cmd_request->bounce_sgl_count);
 
                kmem_cache_free(host_dev->request_pool, cmd_request);