gsettings: remove bad signal connection
authorTanu Kaskinen <tanuk@iki.fi>
Tue, 17 Apr 2018 06:07:39 +0000 (09:07 +0300)
committerTanu Kaskinen <tanuk@iki.fi>
Thu, 19 Apr 2018 11:45:13 +0000 (14:45 +0300)
The removed g_signal_connect() call didn't make sense. The callback
expects to be called when individual module groups are changed, not when
the top level object is changed. Also, module_group_callback() expects
user_data to be non-NULL, but here it was set to NULL.

src/modules/gsettings/gsettings-helper.c

index 5d1d210..cf047e2 100644 (file)
@@ -88,8 +88,6 @@ int main(int argc, char *argv[]) {
     if (!(settings = g_settings_new(PA_GSETTINGS_MODULE_GROUPS_SCHEMA)))
         goto fail;
 
-    g_signal_connect(settings, "changed", (GCallback) module_group_callback, NULL);
-
     group_names = g_settings_list_children(settings);
 
     for (name = group_names; *name; name++) {