net: phy: tja11xx: use phy_read_poll_timeout() to simplify the code

use phy_read_poll_timeout() to replace the poll codes for
simplify tja11xx_check() function.

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c
index b705d0b..47caae7 100644 (file)
--- a/drivers/net/phy/nxp-tja11xx.c
+++ b/drivers/net/phy/nxp-tja11xx.c
@@ -72,20 +72,10 @@ static struct tja11xx_phy_stats tja11xx_hw_stats[] = {
 
 static int tja11xx_check(struct phy_device *phydev, u8 reg, u16 mask, u16 set)
 {
-       int i, ret;
-
-       for (i = 0; i < 200; i++) {
-               ret = phy_read(phydev, reg);
-               if (ret < 0)
-                       return ret;
-
-               if ((ret & mask) == set)
-                       return 0;
-
-               usleep_range(100, 150);
-       }
+       int val;
 
-       return -ETIMEDOUT;
+       return phy_read_poll_timeout(phydev, reg, val, (val & mask) == set,
+                                    150, 30000, false);
 }
 
 static int phy_modify_check(struct phy_device *phydev, u8 reg,