[clang-tidy] Avoid duplicated DenseMap lookup.
authorBenjamin Kramer <benny.kra@googlemail.com>
Thu, 21 Jul 2016 14:13:45 +0000 (14:13 +0000)
committerBenjamin Kramer <benny.kra@googlemail.com>
Thu, 21 Jul 2016 14:13:45 +0000 (14:13 +0000)
The std::string is still constructed on demand. No functionality change
intended.

llvm-svn: 276282

clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

index d0a7e5f..619c0c1 100644 (file)
@@ -176,8 +176,7 @@ DiagnosticBuilder ClangTidyContext::diag(
   assert(Loc.isValid());
   unsigned ID = DiagEngine->getDiagnosticIDs()->getCustomDiagID(
       Level, (Description + " [" + CheckName + "]").str());
-  if (CheckNamesByDiagnosticID.count(ID) == 0)
-    CheckNamesByDiagnosticID.insert(std::make_pair(ID, CheckName.str()));
+  CheckNamesByDiagnosticID.try_emplace(ID, CheckName);
   return DiagEngine->Report(Loc, ID);
 }