media: dvb-frontends: Remove redundant error check on variable ret
authorColin Ian King <colin.king@canonical.com>
Tue, 23 Mar 2021 14:00:47 +0000 (15:00 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 9 Apr 2021 11:00:59 +0000 (13:00 +0200)
An earlier commit removed a call to lgdt3306a_spectral_inversion and
omitted to remove the error return check. The check on ret is now
redundant and can be removed.

Addresses-Coverity: ("Logically dead code")

Fixes: d4a3fa6652e3 ("media: dvb-frontends: lgdt3306a.c: remove dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/lgdt3306a.c

index 22d4844..136b76c 100644 (file)
@@ -1017,9 +1017,6 @@ static int lgdt3306a_set_parameters(struct dvb_frontend *fe)
 
        /* spectral_inversion defaults already set for VSB and QAM */
 
-       if (lg_chkerr(ret))
-               goto fail;
-
        ret = lgdt3306a_mpeg_mode(state, state->cfg->mpeg_mode);
        if (lg_chkerr(ret))
                goto fail;