projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
45c0cba
)
spi: mt7621: fix missing clk_disable_unprepare() on error in mt7621_spi_probe
author
Qinglang Miao
<miaoqinglang@huawei.com>
Tue, 3 Nov 2020 07:49:12 +0000
(15:49 +0800)
committer
Mark Brown
<broonie@kernel.org>
Mon, 9 Nov 2020 19:44:26 +0000
(19:44 +0000)
Fix the missing clk_disable_unprepare() before return
from mt7621_spi_probe in the error handling case.
Fixes:
cbd66c626e16
("spi: mt7621: Move SPI driver out of staging")
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Link:
https://lore.kernel.org/r/20201103074912.195576-1-miaoqinglang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt7621.c
patch
|
blob
|
history
diff --git
a/drivers/spi/spi-mt7621.c
b/drivers/spi/spi-mt7621.c
index
2c3b7a2
..
2cdae79
100644
(file)
--- a/
drivers/spi/spi-mt7621.c
+++ b/
drivers/spi/spi-mt7621.c
@@
-353,6
+353,7
@@
static int mt7621_spi_probe(struct platform_device *pdev)
master = spi_alloc_master(&pdev->dev, sizeof(*rs));
if (!master) {
dev_info(&pdev->dev, "master allocation failed\n");
+ clk_disable_unprepare(clk);
return -ENOMEM;
}
@@
-377,6
+378,7
@@
static int mt7621_spi_probe(struct platform_device *pdev)
ret = device_reset(&pdev->dev);
if (ret) {
dev_err(&pdev->dev, "SPI reset failed!\n");
+ clk_disable_unprepare(clk);
return ret;
}