ASoC: codecs: rt1316: do not store status in state container
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 18 May 2023 07:27:43 +0000 (09:27 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 18 May 2023 10:25:17 +0000 (19:25 +0900)
Driver in its update status callback stores Soundwire device status in
state container but it never uses it later.  Simplify the code a bit.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com
Link: https://lore.kernel.org/r/20230518072753.7361-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org
sound/soc/codecs/rt1316-sdw.c
sound/soc/codecs/rt1316-sdw.h

index 2ee5e76..601b763 100644 (file)
@@ -323,9 +323,6 @@ static int rt1316_update_status(struct sdw_slave *slave,
 {
        struct  rt1316_sdw_priv *rt1316 = dev_get_drvdata(&slave->dev);
 
-       /* Update the status */
-       rt1316->status = status;
-
        if (status == SDW_SLAVE_UNATTACHED)
                rt1316->hw_init = false;
 
@@ -333,7 +330,7 @@ static int rt1316_update_status(struct sdw_slave *slave,
         * Perform initialization only if slave status is present and
         * hw_init flag is false
         */
-       if (rt1316->hw_init || rt1316->status != SDW_SLAVE_ATTACHED)
+       if (rt1316->hw_init || status != SDW_SLAVE_ATTACHED)
                return 0;
 
        /* perform I/O transfers required for Slave initialization */
index e371216..dc1bfe4 100644 (file)
@@ -42,7 +42,6 @@ struct rt1316_sdw_priv {
        struct snd_soc_component *component;
        struct regmap *regmap;
        struct sdw_slave *sdw_slave;
-       enum sdw_slave_status status;
        struct sdw_bus_params params;
        bool hw_init;
        bool first_hw_init;