vtdec: We shouldn't manually check reconfigure flag on pads but instead implement...
authorSebastian Dröge <sebastian@centricular.com>
Fri, 8 May 2015 12:55:28 +0000 (14:55 +0200)
committerSebastian Dröge <sebastian@centricular.com>
Fri, 8 May 2015 13:08:18 +0000 (15:08 +0200)
Add FIXME comment related to that.

sys/applemedia/vtdec.c

index a696fcfcc1cd564ed30e5444c653102cd8ec3003..8c22e24d28541dbd286dcf619964ad4b80a41cf9 100644 (file)
@@ -704,6 +704,9 @@ gst_vtdec_push_frames_if_needed (GstVtdec * vtdec, gboolean drain,
   GstFlowReturn ret = GST_FLOW_OK;
   GstVideoDecoder *decoder = GST_VIDEO_DECODER (vtdec);
 
+  /* FIXME: Instead of this, implement GstVideoDecoder::negotiate() and
+   * just call gst_video_decoder_negotiate()
+   */
   /* negotiate now so that we know whether we need to use the GL upload meta or
    * not */
   if (gst_pad_check_reconfigure (decoder->srcpad)) {