Make this part of the code at least look similar

First we assert that s != NULL.

Then we check if a != NULL, and return -1 if it is. That just makes no sense.

Change the check for a to also be an assertion, and make things at least look similar.

diff --git a/nbdsrv.c b/nbdsrv.c
index 508ac27..8a388d3 100644 (file)
--- a/nbdsrv.c
+++ b/nbdsrv.c
@@ -198,9 +198,7 @@ int append_serve(const SERVER *const s, GArray *const a) {
        int ret;
 
        assert(s != NULL);
-       if(a == NULL) {
-               return -1;
-       }
+       assert(a != NULL);
 
        port = g_strdup_printf("%d", s->port);