media: em28xx-input: make const array addr_list static
authorColin Ian King <colin.king@canonical.com>
Fri, 8 Mar 2019 10:30:17 +0000 (05:30 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 19 Mar 2019 20:53:18 +0000 (16:53 -0400)
Don't populate the array addr_list on the stack but instead make it
static. Makes the object code smaller by 20 bytes

Before:
   text    data     bss     dec     hex filename^M
  16929    3626     384   20939    51cb ../usb/em28xx/em28xx-input.o

After:
   text    data     bss     dec     hex filename^M
  16829    3706     384   20919    51b7 ../usb/em28xx/em28xx-input.o

(gcc version 8.3.0, aarch64)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/em28xx/em28xx-input.c

index f84a120..d85ea1a 100644 (file)
@@ -499,7 +499,7 @@ static int em28xx_probe_i2c_ir(struct em28xx *dev)
         * at address 0x18, so if that address is needed for another board in
         * the future, please put it after 0x1f.
         */
-       const unsigned short addr_list[] = {
+       static const unsigned short addr_list[] = {
                 0x1f, 0x30, 0x47, I2C_CLIENT_END
        };