pwm: visconti: Simplify using devm_pwmchip_add()

This allows to drop the platform_driver's remove function. This is the
only user of driver data so this can go away, too.

Signed-off-by: zhaoxiao <long870912@gmail.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>

diff --git a/drivers/pwm/pwm-visconti.c b/drivers/pwm/pwm-visconti.c
index af4e37d3e3a6705f5711bd5134771b43061ca837..927c4cbb1daf0165b4d7c26393c4d05d7bbe904b 100644 (file)
--- a/drivers/pwm/pwm-visconti.c
+++ b/drivers/pwm/pwm-visconti.c
@@ -144,28 +144,17 @@ static int visconti_pwm_probe(struct platform_device *pdev)
        if (IS_ERR(priv->base))
                return PTR_ERR(priv->base);
 
-       platform_set_drvdata(pdev, priv);
-
        priv->chip.dev = dev;
        priv->chip.ops = &visconti_pwm_ops;
        priv->chip.npwm = 4;
 
-       ret = pwmchip_add(&priv->chip);
+       ret = devm_pwmchip_add(&pdev->dev, &priv->chip);
        if (ret < 0)
                return dev_err_probe(&pdev->dev, ret, "Cannot register visconti PWM\n");
 
        return 0;
 }
 
-static int visconti_pwm_remove(struct platform_device *pdev)
-{
-       struct visconti_pwm_chip *priv = platform_get_drvdata(pdev);
-
-       pwmchip_remove(&priv->chip);
-
-       return 0;
-}
-
 static const struct of_device_id visconti_pwm_of_match[] = {
        { .compatible = "toshiba,visconti-pwm", },
        { }
@@ -178,7 +167,6 @@ static struct platform_driver visconti_pwm_driver = {
                .of_match_table = visconti_pwm_of_match,
        },
        .probe = visconti_pwm_probe,
-       .remove = visconti_pwm_remove,
 };
 module_platform_driver(visconti_pwm_driver);