Replace '#warning' directive with '#pragma message'
authorSeungSeop Park <sns.park@samsung.com>
Mon, 18 Jan 2016 08:53:37 +0000 (17:53 +0900)
committerYoungsoo Choi <kenshin.choi@samsung.com>
Tue, 10 Jul 2018 07:55:23 +0000 (07:55 +0000)
If turn on '-Werror' option, '#warning' will be treated as an error,
which however cannot be suppressed even with "-Wno-error=cpp" option.

As a workaround, patch instead uses "#pragma message" which is information
only and is neither a warning nor an error.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15612

Reviewed by: sns.park

Change-Id: Icfbe90bcd9d9817307704189755d413a808fcc22
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
tizen_src/chromium_impl/content/browser/renderer_host/disambiguation_popup_efl.cc
tizen_src/chromium_impl/ui/base/clipboard/clipboard_helper_efl.cc
tizen_src/ewk/efl_integration/browser/navigation_policy_handler_efl.cc
tizen_src/ewk/efl_integration/memory_purger.cc
tizen_src/ewk/efl_integration/public/ewk_settings.cc

index 3e8e3f6..90241dc 100644 (file)
@@ -97,7 +97,7 @@ void DisambiguationPopupEfl::Show(const gfx::Rect& target,
   content_image_ = evas_object_image_add(evas_object_evas_get(parent_view_));
   elm_object_content_set(popup_, content_image_);
 
-#warning "Add proper support for EFL Assist"
+#pragma message "Add proper support for EFL Assist"
 #if 0 //defined(OS_TIZEN_MOBILE)
   if (EflAssistHandle) {
     typedef void (*cb_type)(Evas_Object*, Ea_Callback_Type, Ea_Event_Cb func, void*);
index 2b11eed..8eded7f 100644 (file)
@@ -55,7 +55,7 @@ struct ClipData
   int bufferLength;
 
   ClipboardHelperEfl* clipboardHelper;
-#warning "TODO: Add proper delegate class for clipboard related functionality EWK needs."
+#pragma message "TODO: Add proper delegate class for clipboard related functionality EWK needs."
   EWebView* webView;
 };
 
index 6914c97..7dde2b8 100644 (file)
@@ -24,7 +24,7 @@ NavigationPolicyHandlerEfl::~NavigationPolicyHandlerEfl() {
 void NavigationPolicyHandlerEfl::DownloadNavigation() {
   // indicate that we handle it
   if (SetDecision(Handled)) {
-#warning "[M37] RequestOpenURL was moved to WebContentsImpl, how to access it from here?"
+#pragma message "[M37] RequestOpenURL was moved to WebContentsImpl, how to access it from here?"
     //WindowOpenDisposition disposition = SAVE_TO_DISK;
     //rvh_->GetDelegate()->RequestOpenURL(rvh_, params_.url, params_.referrer,
     //    disposition, params_.frame_id, params_.is_redirect, false);
index c6f063c..1f79b4d 100644 (file)
@@ -57,7 +57,7 @@ void PurgeMemoryIOHelper::AddRequestContextGetter(
 void PurgeMemoryIOHelper::PurgeMemoryOnIOThread() {
   // Ask ProxyServices to purge any memory they can (generally garbage in the
   // wrapped ProxyResolver's JS engine).
-#warning "[M37] Fix memory purge"
+#pragma message "[M37] Fix memory purge"
 #if 0
   for (size_t i = 0; i < request_context_getters_.size(); ++i) {
     request_context_getters_[i]->GetURLRequestContext()->proxy_service()->
@@ -80,13 +80,13 @@ void MemoryPurger::PurgeAll(BrowserContext* browser_context) {
 // static
 void MemoryPurger::PurgeBrowser(BrowserContext* browser_context) {
   // Dump the backing stores.
-#warning "[M37] backing stores were removed, so the code below is probably safe to remove, check this."
+#pragma message "[M37] backing stores were removed, so the code below is probably safe to remove, check this."
   //content::RenderWidgetHost::RemoveAllBackingStores();
   scoped_refptr<PurgeMemoryIOHelper> purge_memory_io_helper(
       new PurgeMemoryIOHelper());
   purge_memory_io_helper->AddRequestContextGetter(
         make_scoped_refptr(browser_context->GetRequestContext()));
-#warning "[M37] Another non existing function"
+#pragma message "[M37] Another non existing function"
   //BrowserContext::PurgeMemory(browser_context);
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
index d8dd663..98d20b0 100644 (file)
@@ -39,7 +39,7 @@ void ewkUpdateWebkitPreferences(Evas_Object *ewkView)
 Eina_Bool ewk_settings_fullscreen_enabled_set(Ewk_Settings* settings, Eina_Bool enable)
 {
 #if !defined(EWK_BRINGUP)
-#warning "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
+#pragma message "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
   settings->getPreferences().fullscreen_enabled = enable;
   ewkUpdateWebkitPreferences(settings->getEvasObject());
@@ -52,7 +52,7 @@ Eina_Bool ewk_settings_fullscreen_enabled_set(Ewk_Settings* settings, Eina_Bool
 Eina_Bool ewk_settings_fullscreen_enabled_get(const Ewk_Settings* settings)
 {
 #if !defined(EWK_BRINGUP)
-#warning "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
+#pragma message "[M38] fullscreen_enabled flag has been deleted from webpreference.h"
   EINA_SAFETY_ON_NULL_RETURN_VAL(settings, false);
   return settings->getPreferences().fullscreen_enabled;
 #else