Fix bugs about web TCT

Change-Id: I915b7614dde29cb1055d875a4f4dc48567645624
Signed-off-by: jh9216.park <jh9216.park@samsung.com>

diff --git a/modules/badge/badge_service.cc b/modules/badge/badge_service.cc
index be37f8af1038e16671f3a21ee4f70159a406e207..2f313d1692518d25dcbe49324cc64999bc97763e 100644 (file)
--- a/modules/badge/badge_service.cc
+++ b/modules/badge/badge_service.cc
@@ -310,4 +310,16 @@ void BadgeService::NotifyChangedEvent(rpc::BadgeInfo::Action action,
   changed_cb_->Invoke(action, appid, count);
 }
 
+bool BadgeService::IsExisting(std::string appid, bool& existing) {
+  try {
+    tizen_base::Database db(BADGE_DB_PATH, SQLITE_OPEN_READONLY);
+    auto ret = IsExist(db, appid);
+    existing = ret;
+  } catch (...) {
+    return false;
+  }
+
+  return true;
+}
+
 }  // namespace esd::module

diff --git a/modules/badge/badge_service.hh b/modules/badge/badge_service.hh
index 827e62d35a0dd1c11a37cec004efa5ba81096c9c..eb1746f681a9bddf012ad374d777f7cb2705f9f6 100644 (file)
--- a/modules/badge/badge_service.hh
+++ b/modules/badge/badge_service.hh
@@ -64,6 +64,7 @@ class BadgeService : public rpc_stub::Badge::ServiceBase {
   bool GetDisplayOption(std::string appid) override;
   bool Register(std::unique_ptr<rpc_stub::Badge::ChangedCb> cb) override;
   bool Unregister() override;
+  bool IsExisting(std::string appid, bool& existing);
 
   void NotifyChangedEvent(rpc::BadgeInfo::Action action,
       const std::string& appid, int count);

diff --git a/src/badge.cc b/src/badge.cc
index fa7015881499ddb407f6e8a575cf66a8981737f6..fed90379442e250430e5c9925e7bbfe412e97f2d 100644 (file)
--- a/src/badge.cc
+++ b/src/badge.cc
@@ -300,3 +300,47 @@ EXPORT_API int badge_unregister_changed_cb(badge_change_cb callback) {
 
   return BADGE_ERROR_NONE;
 }
+
+// Internal APIs
+extern "C" EXPORT_API int badge_create(const char* pkgname,
+                                       const char* writable_pkg) {
+  LOGW(
+      "DEPRECATION WARNING: badge_create() is deprecated and will be removed "
+      "from "
+      "next release.");
+  CHECK_BADGE_FEATURE();
+  try {
+    ::Connect();
+    if (!badge_proxy_->Insert(pkgname, writable_pkg, sAppid))
+      return BADGE_ERROR_IO_ERROR; /* LCOV_EXCL_LINE */
+  } catch (...) {                  /* LCOV_EXCL_LINE */
+    /* LCOV_EXCL_START */
+    badge_proxy_.reset();
+    return BADGE_ERROR_IO_ERROR;
+    /* LCOV_EXCL_STOP */
+  }
+
+  return BADGE_ERROR_NONE;
+}
+
+extern "C" EXPORT_API int badge_is_existing(const char* app_id,
+                                            bool* existing) {
+  LOGW(
+      "DEPRECATION WARNING: badge_is_existing() is deprecated and will be "
+      "removed "
+      "from "
+      "next release.");
+  CHECK_BADGE_FEATURE();
+  try {
+    ::Connect();
+    if (!badge_proxy_->IsExisting(app_id, *existing))
+      return BADGE_ERROR_IO_ERROR; /* LCOV_EXCL_LINE */
+  } catch (...) {                  /* LCOV_EXCL_LINE */
+    /* LCOV_EXCL_START */
+    badge_proxy_.reset();
+    return BADGE_ERROR_IO_ERROR;
+    /* LCOV_EXCL_STOP */
+  }
+
+  return BADGE_ERROR_NONE;
+}

diff --git a/src/badge_internal.cc b/src/badge_internal.cc
index 8d3f25fd63413ff328683d8deb6f5a56781b8f34..f8df65aaf706cfd36e1e50da3eb026e0bb93026b 100644 (file)
--- a/src/badge_internal.cc
+++ b/src/badge_internal.cc
@@ -121,18 +121,6 @@ int badge_del_deferred_task(
   return BADGE_ERROR_NOT_SUPPORTED;
 }
 
-EXPORT_API
-int badge_is_existing(const char* app_id, bool* existing)
-{
-  return BADGE_ERROR_NOT_SUPPORTED;
-}
-
-EXPORT_API
-int badge_create(const char* pkgname, const char* writable_pkg)
-{
-  return BADGE_ERROR_NOT_SUPPORTED;
-}
-
 EXPORT_API int badge_setting_get_pkgname(badge_setting_h setting, char** pkgname)
 {
   return BADGE_ERROR_NOT_SUPPORTED;
@@ -163,7 +151,7 @@ EXPORT_API int badge_setting_update_setting(badge_setting_h setting)
   return BADGE_ERROR_NOT_SUPPORTED;
 }
 
-EXPORT_API int d(badge_setting_h* setting, const char* appid, uid_t uid)
+EXPORT_API int badge_setting_get_setting_by_appid_for_uid(badge_setting_h* setting, const char* appid, uid_t uid)
 {
   return BADGE_ERROR_NOT_SUPPORTED;
 }

diff --git a/tidl/badge.tidl b/tidl/badge.tidl
index 9f1808afa2c0312a1431c61a44f4a3f0c8c4c409..b0dcae7d5613846f8f1b81929f7689376e8392c2 100755 (executable)
--- a/tidl/badge.tidl
+++ b/tidl/badge.tidl
@@ -26,4 +26,5 @@ interface Badge {
   bool GetDisplayOption(string appid);\r
   bool Register(ChangedCb cb);\r
   bool Unregister();\r
+  bool IsExisting(string appid, out bool existing);\r
 }\r