thermal: qcom-spmi-adc-tm5: suppress probe-deferral error message
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 2 Nov 2022 15:26:30 +0000 (16:26 +0100)
committerDaniel Lezcano <daniel.lezcano@kernel.org>
Wed, 14 Dec 2022 14:25:40 +0000 (15:25 +0100)
Drivers should not be logging errors on probe deferral. Switch to using
dev_err_probe() to log failures when parsing the devicetree to avoid
errors like:

qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: get dt data failed: -517

when a channel is not yet available.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Andrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20221102152630.696-1-johan+linaro@kernel.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
drivers/thermal/qcom/qcom-spmi-adc-tm5.c

index 1b2c43e..88462a4 100644 (file)
@@ -1030,10 +1030,8 @@ static int adc_tm5_probe(struct platform_device *pdev)
                return irq;
 
        ret = adc_tm5_get_dt_data(adc_tm, node);
-       if (ret) {
-               dev_err(dev, "get dt data failed: %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "get dt data failed\n");
 
        ret = adc_tm->data->init(adc_tm);
        if (ret) {