[NextBrowser] fixup! Disabling Bookmarks Button on Internal Pages

-When URL starts with "chrome://", the Bookmark button will not be shown

Change-Id: I523ee52ee510a2c2c335eea43cc86d5b83c4e330
Signed-off-by: rcanada <r.canada@samsung.com>

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index 0430b9a48e5d0dde5ba2a77366f1d46de8d1fd11..bcb281e9640c9bea5508c7732d7cb67e4425cff7 100644 (file)
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -922,6 +922,20 @@ void LocationBarView::Update(WebContents* contents) {
   if (qr_generator_icon)
     qr_generator_icon->SetVisible(false);
 
+  PageActionIconView* bookmark_star_icon =
+      page_action_icon_controller_->GetIconView(
+          PageActionIconType::kBookmarkStar);
+
+  if (bookmark_star_icon) {
+    std::string url = base::UTF16ToUTF8(omnibox_view_->GetText());
+    if (url.substr(0, 9).compare("chrome://") == 0 ||
+        omnibox_view_->IsEditingOrEmpty()) {
+      bookmark_star_icon->SetVisible(false);
+    } else {
+      bookmark_star_icon->SetVisible(true);
+    }
+  }
+
   OnChanged();  // NOTE: Calls Layout().
 
   // A permission prompt may be suspended due to an invalid state (empty or