mcb: Use DEFINE_RES_MEM() helper macro and fix the end address
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 16 Jun 2021 07:30:30 +0000 (15:30 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Jun 2021 13:56:25 +0000 (15:56 +0200)
Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the
code a bit shorter and easier to read. The start address does not need to
appear twice.

By the way, the value of '.end' should be "start + size - 1". So the
previous writing should have omitted subtracted 1.

Fixes: acf5e051ac44 ("MCB: add support for SC31 to mcb-lpc")
Fixes: 73edc8f7ccef ("mcb: Added support for LPC or non PCI based MCB carrier")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210616073030.834-2-thunder.leizhen@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mcb/mcb-lpc.c

index 5066767..53decd8 100644 (file)
@@ -105,17 +105,8 @@ out_put:
        return ret;
 }
 
-static struct resource sc24_fpga_resource = {
-       .start = 0xe000e000,
-       .end = 0xe000e000 + CHAM_HEADER_SIZE,
-       .flags = IORESOURCE_MEM,
-};
-
-static struct resource sc31_fpga_resource = {
-       .start = 0xf000e000,
-       .end = 0xf000e000 + CHAM_HEADER_SIZE,
-       .flags = IORESOURCE_MEM,
-};
+static struct resource sc24_fpga_resource = DEFINE_RES_MEM(0xe000e000, CHAM_HEADER_SIZE);
+static struct resource sc31_fpga_resource = DEFINE_RES_MEM(0xf000e000, CHAM_HEADER_SIZE);
 
 static struct platform_driver mcb_lpc_driver = {
        .driver         = {