soundwire: intel: (cosmetic) remove multiple superfluous "else" statements
authorGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Fri, 8 May 2020 00:30:46 +0000 (02:30 +0200)
committerVinod Koul <vkoul@kernel.org>
Mon, 11 May 2020 06:12:39 +0000 (11:42 +0530)
No need for an "else" after a "return" statement. Remove multiple such
occurrences in Intel-specific code.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200508003046.23162-3-guennadi.liakhovetski@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c
drivers/soundwire/intel_init.c

index ecd357d..9ea8753 100644 (file)
@@ -407,7 +407,9 @@ cdns_fill_msg_resp(struct sdw_cdns *cdns,
        if (nack) {
                dev_err_ratelimited(cdns->dev, "Msg NACKed for Slave %d\n", msg->dev_num);
                return SDW_CMD_FAIL;
-       } else if (no_ack) {
+       }
+
+       if (no_ack) {
                dev_dbg_ratelimited(cdns->dev, "Msg ignored for Slave %d\n", msg->dev_num);
                return SDW_CMD_IGNORED;
        }
@@ -520,7 +522,9 @@ cdns_program_scp_addr(struct sdw_cdns *cdns, struct sdw_msg *msg)
                dev_err_ratelimited(cdns->dev,
                                    "SCP_addrpage NACKed for Slave %d\n", msg->dev_num);
                return SDW_CMD_FAIL;
-       } else if (no_ack) {
+       }
+
+       if (no_ack) {
                dev_dbg_ratelimited(cdns->dev,
                                    "SCP_addrpage ignored for Slave %d\n", msg->dev_num);
                return SDW_CMD_IGNORED;
index 4b76940..d5d4279 100644 (file)
@@ -86,7 +86,9 @@ static struct sdw_intel_ctx
                dev_err(&adev->dev, "Link count %d exceeds max %d\n",
                        count, SDW_MAX_LINKS);
                return NULL;
-       } else if (!count) {
+       }
+
+       if (!count) {
                dev_warn(&adev->dev, "No SoundWire links detected\n");
                return NULL;
        }