staging: rtl8188eu: remove all RT_TRACE calls from core/rtw_led.c
authorPhillip Potter <phil@philpotter.co.uk>
Fri, 25 Jun 2021 00:07:43 +0000 (01:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Jun 2021 07:03:50 +0000 (09:03 +0200)
Remove all RT_TRACE calls from core/rtw_led.c as this macro is
unnecessary, and these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210625000756.6313-11-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_led.c

index 7bf05bb..be868f3 100644 (file)
@@ -92,15 +92,10 @@ static void SwLedBlink1(struct LED_871x *pLed)
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
 
        /*  Change LED according to BlinkingLedState specified. */
-       if (pLed->BlinkingLedState == RTW_LED_ON) {
+       if (pLed->BlinkingLedState == RTW_LED_ON)
                sw_led_on(padapter, pLed);
-               RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
-                        ("Blinktimes (%d): turn on\n", pLed->BlinkTimes));
-       } else {
+       else
                sw_led_off(padapter, pLed);
-               RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
-                        ("Blinktimes (%d): turn off\n", pLed->BlinkTimes));
-       }
 
        if (padapter->pwrctrlpriv.rf_pwrstate != rf_on) {
                sw_led_off(padapter, pLed);
@@ -137,7 +132,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                        pLed->BlinkingLedState = RTW_LED_ON;
                                mod_timer(&pLed->BlinkTimer, jiffies +
                                          msecs_to_jiffies(LED_BLINK_LINK_INTERVAL_ALPHA));
-                               RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
                        } else if (!check_fwstate(pmlmepriv, _FW_LINKED)) {
                                pLed->bLedNoLinkBlinkInProgress = true;
                                pLed->CurrLedState = LED_BLINK_SLOWLY;
@@ -147,7 +141,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                        pLed->BlinkingLedState = RTW_LED_ON;
                                mod_timer(&pLed->BlinkTimer, jiffies +
                                          msecs_to_jiffies(LED_BLINK_NO_LINK_INTERVAL_ALPHA));
-                               RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
                        }
                        pLed->bLedScanBlinkInProgress = false;
                } else {
@@ -171,7 +164,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                        pLed->BlinkingLedState = RTW_LED_ON;
                                mod_timer(&pLed->BlinkTimer, jiffies +
                                          msecs_to_jiffies(LED_BLINK_LINK_INTERVAL_ALPHA));
-                               RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
                        } else if (!check_fwstate(pmlmepriv, _FW_LINKED)) {
                                pLed->bLedNoLinkBlinkInProgress = true;
                                pLed->CurrLedState = LED_BLINK_SLOWLY;
@@ -181,7 +173,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                        pLed->BlinkingLedState = RTW_LED_ON;
                                mod_timer(&pLed->BlinkTimer, jiffies +
                                          msecs_to_jiffies(LED_BLINK_NO_LINK_INTERVAL_ALPHA));
-                               RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
                        }
                        pLed->bLedBlinkInProgress = false;
                } else {
@@ -211,7 +202,6 @@ static void SwLedBlink1(struct LED_871x *pLed)
                                pLed->BlinkingLedState = RTW_LED_ON;
                        mod_timer(&pLed->BlinkTimer, jiffies +
                                  msecs_to_jiffies(LED_BLINK_LINK_INTERVAL_ALPHA));
-                       RT_TRACE(_module_rtl8712_led_c_, _drv_info_, ("CurrLedState %d\n", pLed->CurrLedState));
 
                        pLed->bLedWPSBlinkInProgress = false;
                } else {
@@ -439,9 +429,6 @@ static void SwLedControlMode1(struct adapter *padapter, enum LED_CTL_MODE LedAct
        default:
                break;
        }
-
-       RT_TRACE(_module_rtl8712_led_c_, _drv_info_,
-                ("Led %d\n", pLed->CurrLedState));
 }
 
 void blink_handler(struct LED_871x *pLed)