watchdog: da9063: rename helper function to avoid misunderstandings
authorMarco Felsch <m.felsch@pengutronix.de>
Mon, 4 Jun 2018 15:00:58 +0000 (17:00 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Thu, 7 Jun 2018 10:41:42 +0000 (12:41 +0200)
_da9063_wdt_set_timeout() is called by da9063_wdg_set_timeout(),
da9063_wdg_start() and da9063_wdg_probe() but the name expect only to be
called by da9063_wdg_set_timeout(). Rename the function to avoid
misunderstandings.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/da9063_wdt.c

index a4380a8..760aa9b 100644 (file)
@@ -64,7 +64,7 @@ static int da9063_wdt_disable_timer(struct da9063 *da9063)
                                  DA9063_TWDSCALE_DISABLE);
 }
 
-static int _da9063_wdt_set_timeout(struct da9063 *da9063, unsigned int regval)
+static int da9063_wdt_update_timeout(struct da9063 *da9063, unsigned int regval)
 {
        int ret;
 
@@ -93,7 +93,7 @@ static int da9063_wdt_start(struct watchdog_device *wdd)
        int ret;
 
        selector = da9063_wdt_timeout_to_sel(wdd->timeout);
-       ret = _da9063_wdt_set_timeout(da9063, selector);
+       ret = da9063_wdt_update_timeout(da9063, selector);
        if (ret)
                dev_err(da9063->dev, "Watchdog failed to start (err = %d)\n",
                        ret);
@@ -148,7 +148,7 @@ static int da9063_wdt_set_timeout(struct watchdog_device *wdd,
         * enabling the watchdog, so the timeout must be buffered by the driver.
         */
        if (watchdog_active(wdd))
-               ret = _da9063_wdt_set_timeout(da9063, selector);
+               ret = da9063_wdt_update_timeout(da9063, selector);
 
        if (ret)
                dev_err(da9063->dev, "Failed to set watchdog timeout (err = %d)\n",
@@ -223,7 +223,7 @@ static int da9063_wdt_probe(struct platform_device *pdev)
                unsigned int timeout;
 
                timeout = da9063_wdt_timeout_to_sel(DA9063_WDG_TIMEOUT);
-               _da9063_wdt_set_timeout(da9063, timeout);
+               da9063_wdt_update_timeout(da9063, timeout);
                set_bit(WDOG_HW_RUNNING, &wdd->status);
        }