nexthop: remove redundant assignment to err
authorColin Ian King <colin.king@canonical.com>
Thu, 30 May 2019 15:57:54 +0000 (16:57 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 May 2019 21:33:52 +0000 (14:33 -0700)
The variable err is initialized with a value that is never read
and err is reassigned a few statements later. This initialization
is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/nexthop.c

index 1af8a32..7a5a3d0 100644 (file)
@@ -836,7 +836,7 @@ static int nh_create_ipv6(struct net *net,  struct nexthop *nh,
                .fc_encap = cfg->nh_encap,
                .fc_encap_type = cfg->nh_encap_type,
        };
-       int err = -EINVAL;
+       int err;
 
        if (!ipv6_addr_any(&cfg->gw.ipv6))
                fib6_cfg.fc_flags |= RTF_GATEWAY;