Fix SVACE issues

 * UNREACHABLE_CODE_RET

[Version] 15.0.77
[Issue Type] SVACE

Change-Id: Iaee3c582785b23f6b8203e4094fc124f060ce3ab
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>

diff --git a/packaging/pulseaudio-modules-tizen.spec b/packaging/pulseaudio-modules-tizen.spec
index 157bb2ce2bf345ba24e21b28fbdfa9ef7295702e..3c46fa24b044009dc05bb889f668aeb3f4e182bb 100644 (file)
--- a/packaging/pulseaudio-modules-tizen.spec
+++ b/packaging/pulseaudio-modules-tizen.spec
@@ -2,7 +2,7 @@
 
 Name:             pulseaudio-modules-tizen
 Summary:          Pulseaudio modules for Tizen
-Version:          15.0.76
+Version:          15.0.77
 Release:          0
 Group:            Multimedia/Audio
 License:          LGPL-2.1+

diff --git a/src/device-manager.c b/src/device-manager.c
index 6e35e90081404b4b9b3e53c065ca4db79396c515..bf1ad125b6e60fd53e8ffbe3b3dd60f6a07c3d8d 100644 (file)
--- a/src/device-manager.c
+++ b/src/device-manager.c
@@ -2384,7 +2384,7 @@ void handle_device_connected(pa_device_manager *dm, const char *type, const char
     }
 }
 
-static int load_builtin_devices(pa_device_manager *dm) {
+static void load_builtin_devices(pa_device_manager *dm) {
     device_type_info *type_info;
     uint32_t type_idx;
     device_detected_type_t detected_type = DEVICE_CONNECTED;
@@ -2431,8 +2431,6 @@ static int load_builtin_devices(pa_device_manager *dm) {
     }
 
     pa_log_debug("Load Builtin Devices Done");
-
-    return 0;
 }
 
 /***************** Parse json file *******************/
@@ -3216,10 +3214,7 @@ pa_device_manager* pa_device_manager_get(pa_core *c) {
 
     device_type_status_init(dm);
 
-    if (load_builtin_devices(dm) != 0) {
-        pa_log_error("Load Builtin Devices failed");
-        return NULL;
-    }
+    load_builtin_devices(dm);
 
     /* Just for convenience when test*/
     if (!_device_manager_set_default_sink(dm,  DEVICE_TYPE_SPEAKER, "normal")) {

diff --git a/src/module-tizenaudio-sink.c b/src/module-tizenaudio-sink.c
index e91aafd3c5a94a6d48a19802e5e50f8116e3e17a..d3b4b0995f93c46997f65506411f394f973c8df3 100644 (file)
--- a/src/module-tizenaudio-sink.c
+++ b/src/module-tizenaudio-sink.c
@@ -436,6 +436,7 @@ static int process_render(struct userdata *u, pa_usec_t now) {
         frame_size = pa_frame_size(&u->sink->sample_spec);
         if (frame_size == 0) {
             pa_log_error("Unexpected frame size zero!");
+            work_done = -1;
             break;
         }
 

diff --git a/src/module-tizenaudio-source.c b/src/module-tizenaudio-source.c
index cc596d3b662e91a61baa9c6acaa8f3e52e9352ea..d7cc3a421c746268740527d4e24695a4d2217739 100644 (file)
--- a/src/module-tizenaudio-source.c
+++ b/src/module-tizenaudio-source.c
@@ -301,6 +301,7 @@ static int process_render(struct userdata *u, pa_usec_t now) {
         frame_size = pa_frame_size(&u->source->sample_spec);
         if (frame_size == 0) {
             pa_log_error("Unexpected frame size zero!");
+            work_done = -1;
             break;
         }