ibmvnic: Assign XPS map to correct queue index
authorNick Child <nnac123@linux.ibm.com>
Thu, 23 Feb 2023 15:39:44 +0000 (09:39 -0600)
committerJakub Kicinski <kuba@kernel.org>
Sat, 25 Feb 2023 02:34:26 +0000 (18:34 -0800)
When setting the XPS map value for TX queues, use the index of the
transmit queue.
Previously, the function was passing the index of the loop that iterates
over all queues (RX and TX). This was causing invalid XPS map values.

Fixes: 6831582937bd ("ibmvnic: Toggle between queue types in affinity mapping")
Signed-off-by: Nick Child <nnac123@linux.ibm.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Link: https://lore.kernel.org/r/20230223153944.44969-1-nnac123@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ibm/ibmvnic.c

index 146ca1d..c63d3ec 100644 (file)
@@ -296,10 +296,10 @@ static void ibmvnic_set_affinity(struct ibmvnic_adapter *adapter)
 
                rc = __netif_set_xps_queue(adapter->netdev,
                                           cpumask_bits(queue->affinity_mask),
-                                          i, XPS_CPUS);
+                                          i_txqs - 1, XPS_CPUS);
                if (rc)
                        netdev_warn(adapter->netdev, "%s: Set XPS on queue %d failed, rc = %d.\n",
-                                   __func__, i, rc);
+                                   __func__, i_txqs - 1, rc);
        }
 
 out: