firmware loader: fix comments on request_firmware_nowait
authorMing Lei <ming.lei@canonical.com>
Sat, 4 Aug 2012 04:01:24 +0000 (12:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Aug 2012 20:28:50 +0000 (13:28 -0700)
request_firmware_nowait is allowed to be called in atomic
context now if @gfp is GFP_ATOMIC, so fix the obsolete
comments and states which situations are suitable for using
it.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/firmware_class.c

index 7d3a83b..a47266c 100644 (file)
@@ -846,9 +846,13 @@ static void request_firmware_work_func(struct work_struct *work)
  *
  *     Caller must hold the reference count of @device.
  *
- *     Asynchronous variant of request_firmware() for user contexts where
- *     it is not possible to sleep for long time. It can't be called
- *     in atomic contexts.
+ *     Asynchronous variant of request_firmware() for user contexts:
+ *             - sleep for as small periods as possible since it may
+ *             increase kernel boot time of built-in device drivers
+ *             requesting firmware in their ->probe() methods, if
+ *             @gfp is GFP_KERNEL.
+ *
+ *             - can't sleep at all if @gfp is GFP_ATOMIC.
  **/
 int
 request_firmware_nowait(