Merge branch 'pci/irq-error'
authorBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Aug 2020 23:24:22 +0000 (18:24 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Wed, 5 Aug 2020 23:24:22 +0000 (18:24 -0500)
- Remove redundant logging for platform_get_irq() errors (Krzysztof
  WilczyƄski)

* pci/irq-error:
  PCI: Remove dev_err() when handing an error from platform_get_irq()

16 files changed:
1  2 
drivers/pci/controller/dwc/pci-dra7xx.c
drivers/pci/controller/dwc/pci-exynos.c
drivers/pci/controller/dwc/pci-imx6.c
drivers/pci/controller/dwc/pci-keystone.c
drivers/pci/controller/dwc/pcie-armada8k.c
drivers/pci/controller/dwc/pcie-artpec6.c
drivers/pci/controller/dwc/pcie-histb.c
drivers/pci/controller/dwc/pcie-kirin.c
drivers/pci/controller/dwc/pcie-spear13xx.c
drivers/pci/controller/mobiveil/pcie-mobiveil-host.c
drivers/pci/controller/pci-tegra.c
drivers/pci/controller/pci-v3-semi.c
drivers/pci/controller/pcie-altera-msi.c
drivers/pci/controller/pcie-altera.c
drivers/pci/controller/pcie-rockchip-host.c
drivers/pci/controller/pcie-xilinx-nwl.c

@@@ -625,12 -626,11 +625,10 @@@ static int __init dra7xx_add_pcie_port(
        struct dw_pcie *pci = dra7xx->pci;
        struct pcie_port *pp = &pci->pp;
        struct device *dev = pci->dev;
 -      struct resource *res;
  
        pp->irq = platform_get_irq(pdev, 1);
-       if (pp->irq < 0) {
-               dev_err(dev, "missing IRQ resource\n");
+       if (pp->irq < 0)
                return pp->irq;
-       }
  
        ret = dra7xx_pcie_init_irq_domain(pp);
        if (ret < 0)
Simple merge
Simple merge
@@@ -762,12 -770,16 +762,11 @@@ static int v3_pci_probe(struct platform
        if (IS_ERR(v3->config_base))
                return PTR_ERR(v3->config_base);
  
 -      ret = pci_parse_request_of_pci_ranges(dev, &host->windows,
 -                                            &host->dma_ranges, NULL);
 -      if (ret)
 -              return ret;
 -
        /* Get and request error IRQ resource */
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "unable to obtain PCIv3 error IRQ\n");
+       if (irq < 0)
                return irq;
-       }
        ret = devm_request_irq(dev, irq, v3_irq, 0,
                        "PCIv3 error", v3);
        if (ret < 0) {
@@@ -694,10 -694,13 +694,9 @@@ static void altera_pcie_irq_teardown(st
  
  static int altera_pcie_parse_dt(struct altera_pcie *pcie)
  {
--      struct device *dev = &pcie->pdev->dev;
        struct platform_device *pdev = pcie->pdev;
 -      struct resource *cra;
 -      struct resource *hip;
  
 -      cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra");
 -      pcie->cra_base = devm_ioremap_resource(dev, cra);
 +      pcie->cra_base = devm_platform_ioremap_resource_byname(pdev, "Cra");
        if (IS_ERR(pcie->cra_base))
                return PTR_ERR(pcie->cra_base);