Fixed SVACE issues

Change-Id: Iea17c337dfcdadaa794df1d899a18db2d45f67a1
Signed-off-by: Rahul Dadhich <r.dadhich@samsung.com>

diff --git a/src/2dview/gl-timeline.c b/src/2dview/gl-timeline.c
index 8119664..0137b90 100644 (file)
--- a/src/2dview/gl-timeline.c
+++ b/src/2dview/gl-timeline.c
@@ -2432,7 +2432,6 @@ static void __gl_timeline_thumbs_create_thumb_cb(media_content_error_e error,
        thumb_data->b_create_thumb = false;
        if (error == MEDIA_CONTENT_ERROR_NONE && GL_FILE_EXISTS(path) &&
                g_strcmp0(path, GL_ICON_DB_DEFAULT_THUMB)) {
-               GL_CHECK(thumb_data);
                /* Update thumb path */
                GL_FREEIF(thumb_data->thumb_url);
                thumb_data->thumb_url = strdup(path);
@@ -2523,7 +2522,6 @@ static Evas_Object *__gl_timeline_thumbs_get_content(void *data, Evas_Object *ob
        GL_CHECK_NULL(strlen(part));
        GL_CHECK_NULL(data);
        gl_media_s *gitem = (gl_media_s *)data;
-       GL_CHECK_NULL(gitem);
        gl_timeline_s *timeline_d = (gl_timeline_s *)evas_object_data_get(obj, "data");
        GL_CHECK_NULL(timeline_d);
        int mode = timeline_d->view_m;
@@ -4001,7 +3999,6 @@ static int __gl_timeline_ctxpopup_append(void *data, Evas_Object *parent)
        gl_dbg("");
        GL_CHECK_VAL(parent, -1);
        GL_CHECK_VAL(data, -1);
-       GL_CHECK_VAL(parent, -1);
        int cnt = 0;
        int ret = -1;
        ret = _gl_data_get_item_cnt(GL_ALBUM_ALL_ID, GL_STORE_T_ALL, &cnt);

diff --git a/src/features/gl-albums-sel.c b/src/features/gl-albums-sel.c
index 7918b3e..2c01a05 100644 (file)
--- a/src/features/gl-albums-sel.c
+++ b/src/features/gl-albums-sel.c
@@ -205,6 +205,9 @@ int _gl_albums_sel_create_view(void *data)
        gl_dbg("Albums length: %d", length);
        if (length > 0) {
                album_item  = eina_list_nth(ad->albuminfo.elist->clist, 0);
+               if (!album_item) {
+                       return -1;
+               }
        } else {
                view = NULL;
                evas_object_del(layout);

diff --git a/src/features/gl-thumbs-sel.c b/src/features/gl-thumbs-sel.c
index 6d097be..a508101 100644 (file)
--- a/src/features/gl-thumbs-sel.c
+++ b/src/features/gl-thumbs-sel.c
@@ -411,6 +411,8 @@ int _gl_thumbs_sel_create_view(void *data, gl_cluster *album_item)
        _gl_thumbs_update_label_text(ad->albuminfo.nf_it_select, total_sel_count, false);
 
        gl_item *gitem_tmp = eina_list_nth(ad->gridinfo.medias_elist, 0);
+       GL_CHECK_VAL(gitem_tmp, -1);
+       GL_CHECK_VAL(gitem_tmp->album, -1);
        GL_CHECK_VAL(gitem_tmp->album->elist, -1);
        if (gitem_tmp->album->elist) {
                int album_select_count = eina_list_count(gitem_tmp->album->elist);
@@ -472,6 +474,9 @@ int _gl_thumbs_sel_update_view(void *data)
 
                gl_item *gitem = NULL;
                gitem = eina_list_nth(ad->gridinfo.medias_elist, 0);
+               if (!gitem) {
+                       return -1;
+               }
                int album_sel_count = eina_list_count(gitem->album->elist);
 
                /* Display selectioninfo */

diff --git a/src/features/gl-thumbs.c b/src/features/gl-thumbs.c
index fee7134..4b2c41a 100644 (file)
--- a/src/features/gl-thumbs.c
+++ b/src/features/gl-thumbs.c
@@ -1822,6 +1822,9 @@ int _gl_thumbs_update_items(void *data)
                /* Display selectioninfo */
                gl_item *gitem = NULL;
                gitem = eina_list_nth(ad->gridinfo.medias_elist, 0);
+               if (!gitem) {
+                       return -1;
+               }
                int album_sel_count = eina_list_count(gitem->album->elist);
                _gl_notify_check_selall(ad, ad->gridinfo.nf_it,
                                        ad->gridinfo.count, album_sel_count);

diff --git a/src/util/gl-exif.c b/src/util/gl-exif.c
index e5a9541..7a09e6d 100644 (file)
--- a/src/util/gl-exif.c
+++ b/src/util/gl-exif.c
@@ -369,6 +369,10 @@ static int __gl_exif_add_exif_to_jfif(char *file_path, unsigned int *orientation
        /* Remove start of JPEG image data section, 20 bytes */
        r_size = fread(tmp, sizeof(char), 20, fd);
 
+       if (r_size > 0) {
+               gl_dbg("r_size: %ld", r_size);
+       }
+
        memset(tmp, 0x00, GL_EXIF_BUF_LEN_MAX);
        /* Write JPEG image data to tmp file after EXIF header */
        while ((r_size = fread(tmp, 1, sizeof(tmp), fd)) > 0) {
@@ -389,7 +393,8 @@ static int __gl_exif_add_exif_to_jfif(char *file_path, unsigned int *orientation
 
        memset(tmp, 0x00, GL_EXIF_BUF_LEN_MAX);
        /* Write back tmp file after to JPEG image */
-       fseek(tmp_fd, 0, SEEK_SET);
+       int val = fseek(tmp_fd, 0, SEEK_SET);
+       gl_dbg("return value is : %d", val);
        while ((r_size = fread(tmp, 1, sizeof(tmp), tmp_fd)) > 0) {
                gl_dbg("r_size: %ld", r_size);
                if (fwrite(tmp, 1, r_size, fd) != r_size) {
@@ -852,7 +857,8 @@ static int __gl_exif_add_orientation_tag(char *file_path,
 
        memset(tmp, 0x00, GL_EXIF_BUF_LEN_MAX);
        /* Write back tmp file after to JPEG image */
-       fseek(tmp_fd, 0, SEEK_SET);
+       int val = fseek(tmp_fd, 0, SEEK_SET);
+       gl_dbg("return value is : %d", val);
        while ((r_size = fread(tmp, 1, sizeof(tmp), tmp_fd)) > 0) {
                gl_dbg("r_size: %ld", r_size);
                if (fwrite(tmp, 1, r_size, fd) != r_size) {

diff --git a/src/util/gl-ext-exec.c b/src/util/gl-ext-exec.c
index 08723bd..49dd1d1 100644 (file)
--- a/src/util/gl-ext-exec.c
+++ b/src/util/gl-ext-exec.c
@@ -208,7 +208,10 @@ int gl_ext_exec(void *data, gl_ext_app_type type)
                }
        } else {
                app_control_set_operation(service, APP_CONTROL_OPERATION_DEFAULT);
-               app_control_set_app_id(service, pkg_name);
+               ret = app_control_set_app_id(service, pkg_name);
+               if (ret != APP_CONTROL_ERROR_NONE) {
+                       gl_dbgE("failed to set app id[%d]!", ret);
+               }
                ret = app_control_send_launch_request(service, NULL, NULL);
                if (ret != APP_CONTROL_ERROR_NONE) {
                        app_control_destroy(service);

diff --git a/src/util/gl-file-util.c b/src/util/gl-file-util.c
index 46c0694..3ead714 100644 (file)
--- a/src/util/gl-file-util.c
+++ b/src/util/gl-file-util.c
@@ -279,7 +279,8 @@ int gl_file_mv(const char *src, const char *dst)
                if (stat(src, &info) == 0) {
                        if (S_ISREG(info.st_mode)) {
                                gl_file_cp(src, dst);
-                               chmod(dst, info.st_mode);
+                               int val = chmod(dst, info.st_mode);
+                               gl_dbg("return value is : %d", val);
                                unlink(src);
                                return 1;
                        }

diff --git a/src/util/gl-util.c b/src/util/gl-util.c
index 93e488e..26989d4 100644 (file)
--- a/src/util/gl-util.c
+++ b/src/util/gl-util.c
@@ -2248,7 +2248,7 @@ char *_gl_get_duration_string(unsigned int v_dur)
        char *dur_str = calloc(1, GL_FILE_PATH_LEN_MAX);
        GL_CHECK_NULL(dur_str);
        if (v_dur > 0) {
-               int duration = floor(v_dur / GL_TIME_MSEC_PER_SEC);
+               int duration = (int)floor(v_dur / GL_TIME_MSEC_PER_SEC);
                int dur_hr = 0;
                int dur_min = 0;
                int dur_sec = 0;

diff --git a/src/widget/gl-editfield.c b/src/widget/gl-editfield.c
index 2a0033d..7b65b31 100644 (file)
--- a/src/widget/gl-editfield.c
+++ b/src/widget/gl-editfield.c
@@ -67,7 +67,6 @@ static void __gl_editfield_space_check_cb(void *data, Evas_Object *obj, void *ei
        *  new name is same as existing name
        */
        g_strstrip((gchar *)entry_utf8);
-       GL_CHECK(entry_utf8);
        gl_sdbg("New entry string without space: [%s]", entry_utf8);
 
        bool b_disabled = false;