drm/i915/lvds: Always return connected in the absence of better information
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 24 Mar 2011 13:26:43 +0000 (13:26 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 24 Mar 2011 18:39:55 +0000 (18:39 +0000)
The LVDS connector should default to connected. We tried our best to
verify the claims of the BIOS that the hardware exists during init(),
and then during detect() we then try to verify that the panel is open.
In the event of an unsuccessful query, we should then always report
that the LVDS panel is connected. This was only the case for gen2/3,
later generations leaked the return value from the panel probe instead.

Reported-and-tested-by: Alessandro Suardi <alessandro.suardi@gmail.com>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Keith Packard <keithp@keithp.com>
drivers/gpu/drm/i915/intel_lvds.c

index 1a311ad..86cd30b 100644 (file)
@@ -473,19 +473,13 @@ static enum drm_connector_status
 intel_lvds_detect(struct drm_connector *connector, bool force)
 {
        struct drm_device *dev = connector->dev;
-       enum drm_connector_status status = connector_status_connected;
+       enum drm_connector_status status;
 
        status = intel_panel_detect(dev);
        if (status != connector_status_unknown)
                return status;
 
-       /* ACPI lid methods were generally unreliable in this generation, so
-        * don't even bother.
-        */
-       if (IS_GEN2(dev) || IS_GEN3(dev))
-               return connector_status_connected;
-
-       return status;
+       return connector_status_connected;
 }
 
 /**