iio: accel: bma400: Fix smatch warning based on use of unintialized value.
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 17 Sep 2022 13:14:01 +0000 (14:14 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Wed, 21 Sep 2022 17:42:57 +0000 (18:42 +0100)
Only specific bits in this value are ever used and those are initialized,
but that is complex to reason about in a checker. Hence, initialize
the value to zero and avoid the complexity.

Smatch warning:
drivers/iio/accel/bma400_core.c:1287 bma400_tap_event_en()
error: uninitialized symbol 'field_value'.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jagath Jog J <jagathjog1996@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Jagath Jog J <jagathjog1996@gmail.com>
Fixes: 961db2da159d ("iio: accel: bma400: Add support for single and double tap events")
Link: https://lore.kernel.org/r/20220917131401.2815486-1-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/bma400_core.c

index eceb1f8..ad8fce3 100644 (file)
@@ -1184,7 +1184,8 @@ static int bma400_activity_event_en(struct bma400_data *data,
                                    enum iio_event_direction dir,
                                    int state)
 {
-       int ret, reg, msk, value, field_value;
+       int ret, reg, msk, value;
+       int field_value = 0;
 
        switch (dir) {
        case IIO_EV_DIR_RISING: