ima: Remove redundant policy rule set in add_rules()
authorKrzysztof Struczynski <krzysztof.struczynski@huawei.com>
Mon, 27 Apr 2020 10:28:58 +0000 (12:28 +0200)
committerMimi Zohar <zohar@linux.ibm.com>
Fri, 8 May 2020 02:54:08 +0000 (22:54 -0400)
Function ima_appraise_flag() returns the flag to be set in
temp_ima_appraise depending on the hook identifier passed as an argument.
It is not necessary to set the flag again for the POLICY_CHECK hook.

Signed-off-by: Krzysztof Struczynski <krzysztof.struczynski@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
security/integrity/ima/ima_policy.c

index c334e0dc60831c8383e4f4611066681938840fd5..ea9b991f023211873f52bf9787bdd00baf178182 100644 (file)
@@ -643,11 +643,8 @@ static void add_rules(struct ima_rule_entry *entries, int count,
 
                        list_add_tail(&entry->list, &ima_policy_rules);
                }
-               if (entries[i].action == APPRAISE) {
+               if (entries[i].action == APPRAISE)
                        temp_ima_appraise |= ima_appraise_flag(entries[i].func);
-                       if (entries[i].func == POLICY_CHECK)
-                               temp_ima_appraise |= IMA_APPRAISE_POLICY;
-               }
        }
 }