intel/compiler: Rotate instructions ROR and ROL cannot have source modifiers
authorIan Romanick <ian.d.romanick@intel.com>
Thu, 30 Jul 2020 18:33:03 +0000 (11:33 -0700)
committerMarge Bot <eric+marge@anholt.net>
Thu, 19 Nov 2020 21:23:53 +0000 (21:23 +0000)
I checked the Bspec for both Gen11 and Gen12, and it appears that rotate
instructions cannot have source modifiers or saturate modifer.  Saturate
was already handled.

Fixes: 1e92e83856b ("intel/compiler: Emit ROR and ROL instruction")
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7650>

src/intel/compiler/brw_shader.cpp

index c44becf..19acf8f 100644 (file)
@@ -937,6 +937,8 @@ backend_instruction::can_do_source_mods() const
    case BRW_OPCODE_CBIT:
    case BRW_OPCODE_FBH:
    case BRW_OPCODE_FBL:
+   case BRW_OPCODE_ROL:
+   case BRW_OPCODE_ROR:
    case BRW_OPCODE_SUBB:
    case SHADER_OPCODE_BROADCAST:
    case SHADER_OPCODE_CLUSTER_BROADCAST: