usb: gadget: composite: correctly initialize ep->maxpacket
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 28 Sep 2016 07:38:11 +0000 (10:38 +0300)
committerSasha Levin <alexander.levin@verizon.com>
Fri, 13 Jan 2017 01:50:07 +0000 (20:50 -0500)
[ Upstream commit e8f29bb719b47a234f33b0af62974d7a9521a52c ]

usb_endpoint_maxp() returns wMaxPacketSize in its
raw form. Without taking into consideration that it
also contains other bits reserved for isochronous
endpoints.

This patch fixes one occasion where this is a
problem by making sure that we initialize
ep->maxpacket only with lower 10 bits of the value
returned by usb_endpoint_maxp(). Note that seperate
patches will be necessary to audit all call sites of
usb_endpoint_maxp() and make sure that
usb_endpoint_maxp() only returns lower 10 bits of
wMaxPacketSize.

Cc: <stable@vger.kernel.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/usb/gadget/composite.c

index 58b4657fc721d3dabda76b2138ea6c30d539992c..9cd76cc8c0d98329f46b3dadb9b59e681ea5061d 100644 (file)
@@ -143,7 +143,7 @@ int config_ep_by_speed(struct usb_gadget *g,
 
 ep_found:
        /* commit results */
-       _ep->maxpacket = usb_endpoint_maxp(chosen_desc);
+       _ep->maxpacket = usb_endpoint_maxp(chosen_desc) & 0x7ff;
        _ep->desc = chosen_desc;
        _ep->comp_desc = NULL;
        _ep->maxburst = 0;