x86/microcode: Adjust late loading result reporting message
authorAshok Raj <ashok.raj@intel.com>
Mon, 9 Jan 2023 15:35:52 +0000 (07:35 -0800)
committerBorislav Petkov (AMD) <bp@alien8.de>
Sat, 21 Jan 2023 13:55:20 +0000 (14:55 +0100)
During late microcode loading, the "Reload completed" message is issued
unconditionally, regardless of success or failure.

Adjust the message to report the result of the update.

  [ bp: Massage. ]

Fixes: 9bd681251b7c ("x86/microcode: Announce reload operation's completion")
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/
arch/x86/kernel/cpu/microcode/core.c

index 8ec38c1..61d57d9 100644 (file)
@@ -453,11 +453,14 @@ static int microcode_reload_late(void)
        store_cpu_caps(&prev_info);
 
        ret = stop_machine_cpuslocked(__reload_late, NULL, cpu_online_mask);
-       if (ret == 0)
+       if (!ret) {
+               pr_info("Reload succeeded, microcode revision: 0x%x -> 0x%x\n",
+                       old, boot_cpu_data.microcode);
                microcode_check(&prev_info);
-
-       pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n",
-               old, boot_cpu_data.microcode);
+       } else {
+               pr_info("Reload failed, current microcode revision: 0x%x\n",
+                       boot_cpu_data.microcode);
+       }
 
        return ret;
 }