Remove unnecessary NYIs in Decompose
authorMichelle McDaniel <adiaaida@gmail.com>
Tue, 13 Sep 2016 18:21:37 +0000 (11:21 -0700)
committerMichelle McDaniel <adiaaida@gmail.com>
Tue, 13 Sep 2016 18:21:37 +0000 (11:21 -0700)
GT_DIV, GT_MOD, GT_UDIV, GT_ROL, GT_ROR, and GT_MULHI will never make it
to decompose, so remove the case statements for those operations. They
will fall through to the default case, which noway_asserts that we haven't
gotten to decompose with an oper that we don't recognize.

Commit migrated from https://github.com/dotnet/coreclr/commit/c1ec8c648d305217d45eb29ff0d1d64cf9e34d0c

src/coreclr/src/jit/decomposelongs.cpp

index 026d05a..4b5f367 100644 (file)
@@ -235,18 +235,6 @@ GenTree* DecomposeLongs::DecomposeNode(GenTree* tree)
             nextNode = DecomposeMul(use);
             break;
 
-        case GT_DIV:
-            NYI("Arithmetic binary operators on TYP_LONG - GT_DIV");
-            break;
-
-        case GT_MOD:
-            NYI("Arithmetic binary operators on TYP_LONG - GT_MOD");
-            break;
-
-        case GT_UDIV:
-            NYI("Arithmetic binary operators on TYP_LONG - GT_UDIV");
-            break;
-
         case GT_UMOD:
             nextNode = DecomposeUMod(use);
             break;
@@ -257,15 +245,6 @@ GenTree* DecomposeLongs::DecomposeNode(GenTree* tree)
             nextNode = DecomposeShift(use);
             break;
 
-        case GT_ROL:
-        case GT_ROR:
-            NYI("Arithmetic binary operators on TYP_LONG - ROTATE");
-            break;
-
-        case GT_MULHI:
-            NYI("Arithmetic binary operators on TYP_LONG - MULHI");
-            break;
-
         case GT_LOCKADD:
         case GT_XADD:
         case GT_XCHG: