Add ATTRIBUTE_PRINTF to printf_field_type_assignment

Get rid of:

/home/simark/src/binutils-gdb/gdb/target-descriptions.c:2026:25: error: format string is not a string literal [-Werror,-Wformat-nonliteral]
    vprintf_unfiltered (fmt, args);

when building with clang.

gdb/ChangeLog:

	* target-descriptions.c (print_c_tdesc)
	<printf_field_type_assignment>: Add ATTRIBUTE_PRINTF.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1b4b13a..c81c611 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-23  Simon Marchi  <simon.marchi@polymtl.ca>
+
+       * target-descriptions.c (print_c_tdesc)
+       <printf_field_type_assignment>: Add ATTRIBUTE_PRINTF.
+
 2017-12-21  Simon Marchi  <simon.marchi@ericsson.com>
            Sergio Durigan Junior  <sergiodj@redhat.com>
 

diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c
index 5dcc4c4..b37f4f0 100644 (file)
--- a/gdb/target-descriptions.c
+++ b/gdb/target-descriptions.c
@@ -2011,6 +2011,7 @@ private:
 
   /* Print an assignment to the field_type variable.  Print the declaration
      of field_type if that has not been done yet.  */
+  ATTRIBUTE_PRINTF (2, 3)
   void printf_field_type_assignment (const char *fmt, ...)
   {
     if (!m_printed_field_type)