Remove unnecessary case of SCARD_ERROR_OK for THROW_ERROR 55/223155/4 accepted/tizen_6.0_unified accepted/tizen_6.0_unified_hotfix tizen_6.0 tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.120547 accepted/tizen/6.0/unified/hotfix/20201103.051600 accepted/tizen/unified/20200210.131738 submit/tizen/20200210.035148 submit/tizen_6.0/20201029.205103 submit/tizen_6.0_hotfix/20201102.192503 submit/tizen_6.0_hotfix/20201103.114803 tizen_6.0.m2_release
authorLokesh <l.kasana@samsung.com>
Thu, 23 Jan 2020 10:44:41 +0000 (16:14 +0530)
committerLokesh <l.kasana@samsung.com>
Wed, 5 Feb 2020 08:39:48 +0000 (14:09 +0530)
THROW_ERROR is always called if errorCode != SCARD_ERROR_OK
Hence switch case of SCARD_ERROR_OK was shown redundant by coverity.

Change-Id: I81a878f8c05e599068662828438201cd8d95dc9d
Signed-off-by: Lokesh <l.kasana@samsung.com>
common/include/Exception.h
packaging/smartcard-service.spec

index 8dc9f9e..82a9f7d 100644 (file)
                { \
                        switch (errorCode) \
                        { \
-                       case SCARD_ERROR_OK : \
-                               /* do nothing */ \
-                               break; \
-               \
                        case SCARD_ERROR_IPC_FAILED : \
                        case SCARD_ERROR_IO_FAILED : \
                        case SCARD_ERROR_OPERATION_TIMEOUT : \
@@ -225,10 +221,6 @@ namespace smartcard_service_api
                {
                        switch (errorCode)
                        {
-                       case SCARD_ERROR_OK :
-                               /* do nothing */
-                               break;
-
                        case SCARD_ERROR_IPC_FAILED :
                        case SCARD_ERROR_IO_FAILED :
                        case SCARD_ERROR_OPERATION_TIMEOUT :
index d996701..3dd4ea2 100755 (executable)
@@ -1,6 +1,6 @@
 Name:       smartcard-service
 Summary:    Smartcard Service FW
-Version:    0.1.58
+Version:    0.1.59
 Release:    0
 Group:      Network & Connectivity
 License:    Apache-2.0