PCI: microchip: Remove dev_err() when handing an error from platform_get_irq()
authorKrzysztof Wilczyński <kw@linux.com>
Wed, 10 Mar 2021 13:19:13 +0000 (13:19 +0000)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 22 Mar 2021 14:25:41 +0000 (14:25 +0000)
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
  drivers/pci/controller/pcie-microchip-host.c:1027:2-9: line 1027 is
  redundant because platform_get_irq() already prints an error

Related commit caecb05c8000 ("PCI: Remove dev_err() when handing an
error from platform_get_irq()").

Link: https://lore.kernel.org/r/20210310131913.2802385-1-kw@linux.com
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
drivers/pci/controller/pcie-microchip-host.c

index 132631cfe4b6242e52ec2ffc8b10abdf74b6d637..89c68c56d93b3a34568e95ecd7b717fb0413ed01 100644 (file)
@@ -1023,10 +1023,8 @@ static int mc_platform_init(struct pci_config_window *cfg)
        }
 
        irq = platform_get_irq(pdev, 0);
-       if (irq < 0) {
-               dev_err(dev, "unable to request IRQ%d\n", irq);
+       if (irq < 0)
                return -ENODEV;
-       }
 
        for (i = 0; i < NUM_EVENTS; i++) {
                event_irq = irq_create_mapping(port->event_domain, i);