[mlir][NFC] GreedyPatternRewriteDriver: Remove overridden eraseOp
authorMatthias Springer <springerm@google.com>
Mon, 16 Jan 2023 15:18:23 +0000 (16:18 +0100)
committerMatthias Springer <springerm@google.com>
Mon, 16 Jan 2023 15:18:53 +0000 (16:18 +0100)
It is not necessary to override `eraseOp`, we can use the existing `notifyOperationRemoved`.

Differential Revision: https://reviews.llvm.org/D141844

mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

index 2cf895e..f0794f8 100644 (file)
@@ -80,9 +80,6 @@ protected:
   // before the root is changed.
   void notifyRootReplaced(Operation *op, ValueRange replacement) override;
 
-  /// PatternRewriter hook for erasing a dead operation.
-  void eraseOp(Operation *op) override;
-
   /// PatternRewriter hook for notifying match failure reasons.
   LogicalResult
   notifyMatchFailure(Location loc,
@@ -394,6 +391,11 @@ void GreedyPatternRewriteDriver::addOperandsToWorklist(ValueRange operands) {
 }
 
 void GreedyPatternRewriteDriver::notifyOperationRemoved(Operation *op) {
+  LLVM_DEBUG({
+    logger.startLine() << "** Erase   : '" << op->getName() << "'(" << op
+                       << ")\n";
+  });
+
   addOperandsToWorklist(op->getOperands());
   op->walk([this](Operation *operation) {
     removeFromWorklist(operation);
@@ -412,14 +414,6 @@ void GreedyPatternRewriteDriver::notifyRootReplaced(Operation *op,
       addToWorklist(user);
 }
 
-void GreedyPatternRewriteDriver::eraseOp(Operation *op) {
-  LLVM_DEBUG({
-    logger.startLine() << "** Erase   : '" << op->getName() << "'(" << op
-                       << ")\n";
-  });
-  PatternRewriter::eraseOp(op);
-}
-
 LogicalResult GreedyPatternRewriteDriver::notifyMatchFailure(
     Location loc, function_ref<void(Diagnostic &)> reasonCallback) {
   LLVM_DEBUG({