drivers: net: smc911x: Fix cast from pointer to integer of different size
authorAndrew Lunn <andrew@lunn.ch>
Tue, 10 Nov 2020 03:02:47 +0000 (04:02 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Nov 2020 22:49:40 +0000 (14:49 -0800)
drivers/net/ethernet/smsc/smc911x.c: In function ‘smc911x_hardware_send_pkt’:
drivers/net/ethernet/smsc/smc911x.c:471:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
  471 |  cmdA = (((u32)skb->data & 0x3) << 16) |

When built on 64bit targets, the skb->data pointer cannot be cast to a
u32 in a meaningful way. Use uintptr_t instead.

Suggested-by: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/smsc/smc911x.c

index ac1a764..22cdbf1 100644 (file)
@@ -465,9 +465,9 @@ static void smc911x_hardware_send_pkt(struct net_device *dev)
                        TX_CMD_A_INT_FIRST_SEG_ | TX_CMD_A_INT_LAST_SEG_ |
                        skb->len;
 #else
-       buf = (char*)((u32)skb->data & ~0x3);
-       len = (skb->len + 3 + ((u32)skb->data & 3)) & ~0x3;
-       cmdA = (((u32)skb->data & 0x3) << 16) |
+       buf = (char *)((uintptr_t)skb->data & ~0x3);
+       len = (skb->len + 3 + ((uintptr_t)skb->data & 3)) & ~0x3;
+       cmdA = (((uintptr_t)skb->data & 0x3) << 16) |
                        TX_CMD_A_INT_FIRST_SEG_ | TX_CMD_A_INT_LAST_SEG_ |
                        skb->len;
 #endif