playbin: subtitleoverlay: don't segfault in incorrectly init'ed plugins

https://bugzilla.gnome.org/show_bug.cgi?id=683865

diff --git a/gst/playback/gstsubtitleoverlay.c b/gst/playback/gstsubtitleoverlay.c
index e42f3818742e3b077287f6973cf10c9f48735dde..e54e875e53f0e2f647f7bfa5b9ffd4ef923a2e2f 100644 (file)
--- a/gst/playback/gstsubtitleoverlay.c
+++ b/gst/playback/gstsubtitleoverlay.c
@@ -191,11 +191,13 @@ _is_renderer (GstElementFactory * factory)
   klass = gst_element_factory_get_klass (factory);
   name = gst_plugin_feature_get_name (GST_PLUGIN_FEATURE_CAST (factory));
 
-  if (strstr (klass, "Overlay/Subtitle") != NULL ||
-      strstr (klass, "Overlay/SubPicture") != NULL)
-    return TRUE;
-  if (strcmp (name, "textoverlay") == 0)
-    return TRUE;
+  if (klass != NULL) {
+    if (strstr (klass, "Overlay/Subtitle") != NULL ||
+        strstr (klass, "Overlay/SubPicture") != NULL)
+      return TRUE;
+    if (strcmp (name, "textoverlay") == 0)
+      return TRUE;
+  }
   return FALSE;
 }
 
@@ -206,7 +208,7 @@ _is_parser (GstElementFactory * factory)
 
   klass = gst_element_factory_get_klass (factory);
 
-  if (strstr (klass, "Parser/Subtitle") != NULL)
+  if (klass != NULL && strstr (klass, "Parser/Subtitle") != NULL)
     return TRUE;
   return FALSE;
 }