efl_ui_layout: call efl_del instead of efl_unref when text part does not exist
authorYeongjong Lee <yj34.lee@samsung.com>
Mon, 18 Mar 2019 12:50:19 +0000 (08:50 -0400)
committerYeongjong Lee <yj34.lee@samsung.com>
Tue, 2 Apr 2019 03:45:17 +0000 (12:45 +0900)
Summary:
Because `efl_isa` doesn't call _efl_object_call_end, the part object is not
removed. it occurs a bunch of efl_unref error message.

Test Plan:
1. elementary_test -to 'efl.ui.box'
2. exit window.
3. check there is no efl_unref error message.

Reviewers: zmike, cedric

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D8385

src/lib/elementary/efl_ui_layout.c

index 6320092..529174f 100644 (file)
@@ -3047,7 +3047,7 @@ elm_layout_text_set(Eo *obj, const char *part, const char *text)
    if (!efl_isa(part_obj, EFL_TEXT_INTERFACE) ||
        !efl_isa(part_obj, EFL_UI_LAYOUT_PART_CLASS))
      {
-        efl_unref(part_obj);
+        efl_del(part_obj);
         return EINA_FALSE;
      }