[lldb/DWARF] Remove DWARFDebugRangesBase abstract class
authorPavel Labath <pavel@labath.sk>
Fri, 6 Dec 2019 09:10:04 +0000 (10:10 +0100)
committerPavel Labath <pavel@labath.sk>
Fri, 6 Dec 2019 09:15:46 +0000 (10:15 +0100)
now that we use llvm to parse debug_rnglists, this abstraction is not
useful.

lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h
lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

index 99ef04d..1888a77 100644 (file)
@@ -17,22 +17,13 @@ namespace lldb_private {
 class DWARFContext;
 }
 
-class DWARFDebugRangesBase {
-public:
-  virtual ~DWARFDebugRangesBase(){};
-
-  virtual void Extract(lldb_private::DWARFContext &context) = 0;
-  virtual bool FindRanges(const DWARFUnit *cu, dw_offset_t debug_ranges_offset,
-                          DWARFRangeList &range_list) const = 0;
-};
-
-class DWARFDebugRanges final : public DWARFDebugRangesBase {
+class DWARFDebugRanges {
 public:
   DWARFDebugRanges();
 
-  void Extract(lldb_private::DWARFContext &context) override;
+  void Extract(lldb_private::DWARFContext &context);
   bool FindRanges(const DWARFUnit *cu, dw_offset_t debug_ranges_offset,
-                  DWARFRangeList &range_list) const override;
+                  DWARFRangeList &range_list) const;
 
   static void Dump(lldb_private::Stream &s,
                    const lldb_private::DWARFDataExtractor &debug_ranges_data,
index 71375da..ab8b3cf 100644 (file)
@@ -883,7 +883,7 @@ uint32_t DWARFUnit::GetHeaderByteSize() const {
 llvm::Expected<DWARFRangeList>
 DWARFUnit::FindRnglistFromOffset(dw_offset_t offset) {
   if (GetVersion() <= 4) {
-    const DWARFDebugRangesBase *debug_ranges = m_dwarf.GetDebugRanges();
+    const DWARFDebugRanges *debug_ranges = m_dwarf.GetDebugRanges();
     if (!debug_ranges)
       return llvm::make_error<llvm::object::GenericBinaryError>(
           "No debug_ranges section");