Remove NYI for x86 long rotate
authorMichelle McDaniel <adiaaida@gmail.com>
Wed, 14 Sep 2016 16:39:16 +0000 (09:39 -0700)
committerMichelle McDaniel <adiaaida@gmail.com>
Wed, 14 Sep 2016 16:42:34 +0000 (09:42 -0700)
For x86 rotate a long by a variable amount, we will just default to what
legacy backend does, which ultimately will generate two helper calls. In
the future, we may want to write a helper function for rotate for these
cases to eliminate one of the helper calls.

Commit migrated from https://github.com/dotnet/coreclr/commit/48c853d0e2ba23e5ceb34b4081697dc80cbfd579

src/coreclr/src/jit/morph.cpp

index 00df17b..7c43507 100644 (file)
@@ -14238,10 +14238,10 @@ GenTreePtr Compiler::fgRecognizeAndMorphBitwiseRotation(GenTreePtr tree)
 #ifndef _TARGET_64BIT_
                             if (!shiftIndexWithoutAdd->IsCnsIntOrI() && (rotatedValueBitSize == 64))
                             {
-                                // TODO: we need to handle variable-sized long shifts specially on x86.
+                                // TODO-X86-CQ: we need to handle variable-sized long shifts specially on x86.
                                 // GT_LSH, GT_RSH, and GT_RSZ have helpers for this case. We may need
                                 // to add helpers for GT_ROL and GT_ROR.
-                                NYI("Rotation of a long value by variable amount");
+                                return tree;
                             }
 #endif