net: usb: pegasus: Replace mdelay() with msleep() in setup_pegasus_II()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 08:36:29 +0000 (16:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 20:45:15 +0000 (13:45 -0700)
setup_pegasus_II() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/pegasus.c

index 6514c86..f4247b2 100644 (file)
@@ -1067,7 +1067,7 @@ static inline void setup_pegasus_II(pegasus_t *pegasus)
 
        set_register(pegasus, Reg1d, 0);
        set_register(pegasus, Reg7b, 1);
-       mdelay(100);
+       msleep(100);
        if ((pegasus->features & HAS_HOME_PNA) && mii_mode)
                set_register(pegasus, Reg7b, 0);
        else