bus: mhi: ep: Check if the channel is supported by the controller
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 28 Dec 2022 16:17:00 +0000 (21:47 +0530)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 27 Jan 2023 07:01:41 +0000 (12:31 +0530)
Before processing the command ring for the channel, check if the channel is
supported by the controller or not.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://lore.kernel.org/r/20221228161704.255268-3-manivannan.sadhasivam@linaro.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/ep/main.c

index 55209d4..8b065a3 100644 (file)
@@ -123,6 +123,13 @@ static int mhi_ep_process_cmd_ring(struct mhi_ep_ring *ring, struct mhi_ring_ele
        int ret;
 
        ch_id = MHI_TRE_GET_CMD_CHID(el);
+
+       /* Check if the channel is supported by the controller */
+       if ((ch_id > mhi_cntrl->max_chan) || !mhi_cntrl->mhi_chan[ch_id].name) {
+               dev_err(dev, "Channel (%u) not supported!\n", ch_id);
+               return -ENODEV;
+       }
+
        mhi_chan = &mhi_cntrl->mhi_chan[ch_id];
        ch_ring = &mhi_cntrl->mhi_chan[ch_id].ring;