projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f5222fb
)
soc: ti: pm33xx: Fix refcount leak in am33xx_pm_probe
author
Miaoqian Lin
<linmq006@gmail.com>
Fri, 6 Jan 2023 05:40:22 +0000
(09:40 +0400)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Thu, 11 May 2023 14:03:07 +0000
(23:03 +0900)
[ Upstream commit
8f3c307b580a4a6425896007325bddefc36e8d91
]
wkup_m3_ipc_get() takes refcount, which should be freed by
wkup_m3_ipc_put(). Add missing refcount release in the error paths.
Fixes:
5a99ae0092fe
("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link:
https://lore.kernel.org/r/20230106054022.947529-1-linmq006@gmail.com
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/ti/pm33xx.c
patch
|
blob
|
history
diff --git
a/drivers/soc/ti/pm33xx.c
b/drivers/soc/ti/pm33xx.c
index
ce09c42
..
f04c211
100644
(file)
--- a/
drivers/soc/ti/pm33xx.c
+++ b/
drivers/soc/ti/pm33xx.c
@@
-527,7
+527,7
@@
static int am33xx_pm_probe(struct platform_device *pdev)
ret = am33xx_pm_alloc_sram();
if (ret)
-
return re
t;
+
goto err_wkup_m3_ipc_pu
t;
ret = am33xx_pm_rtc_setup();
if (ret)
@@
-572,13
+572,14
@@
err_pm_runtime_put:
pm_runtime_put_sync(dev);
err_pm_runtime_disable:
pm_runtime_disable(dev);
- wkup_m3_ipc_put(m3_ipc);
err_unsetup_rtc:
iounmap(rtc_base_virt);
clk_put(rtc_fck);
err_free_sram:
am33xx_pm_free_sram();
pm33xx_dev = NULL;
+err_wkup_m3_ipc_put:
+ wkup_m3_ipc_put(m3_ipc);
return ret;
}