net-PA Semi: Deletion of unnecessary checks before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Sat, 29 Nov 2014 17:55:40 +0000 (18:55 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 6 Dec 2014 05:14:20 +0000 (21:14 -0800)
The pci_dev_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Olof Johansson <olof@lixom.net>
Acked-by: Luis R. Rodriguez <mcgrof@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pasemi/pasemi_mac.c

index 30d934d..44e8d7d 100644 (file)
@@ -1837,10 +1837,8 @@ pasemi_mac_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        return err;
 
 out:
-       if (mac->iob_pdev)
-               pci_dev_put(mac->iob_pdev);
-       if (mac->dma_pdev)
-               pci_dev_put(mac->dma_pdev);
+       pci_dev_put(mac->iob_pdev);
+       pci_dev_put(mac->dma_pdev);
 
        free_netdev(dev);
 out_disable_device: