tty: vcc: Drop unnecessary if block
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 14 Jan 2021 17:57:17 +0000 (18:57 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Jan 2021 09:21:42 +0000 (10:21 +0100)
If vcc_probe() succeeded dev_set_drvdata() is called with a non-NULL
value, and if vcc_probe() failed vcc_remove() isn't called.

So there is no way dev_get_drvdata() can return NULL in vcc_remove() and
the check can just go away.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20210114175718.137483-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/vcc.c

index 9ffd42e..d9b0dc6 100644 (file)
@@ -681,9 +681,6 @@ static int vcc_remove(struct vio_dev *vdev)
 {
        struct vcc_port *port = dev_get_drvdata(&vdev->dev);
 
-       if (!port)
-               return -ENODEV;
-
        del_timer_sync(&port->rx_timer);
        del_timer_sync(&port->tx_timer);